Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm tips for registry maintainers #40170

Merged
merged 1 commit into from
Jul 3, 2021
Merged

rm tips for registry maintainers #40170

merged 1 commit into from
Jul 3, 2021

Conversation

ericphanson
Copy link
Member

This doesn't belong in the General registry's README and the functionality is already covered in RegistryCI's API docs (https://juliaregistries.github.io/RegistryCI.jl/stable/public/#RegistryCI.AutoMerge.run).

@ericphanson ericphanson requested a review from DilumAluthge July 3, 2021 15:46
@ericphanson ericphanson temporarily deployed to stopwatch July 3, 2021 15:46 Inactive
@ericphanson ericphanson mentioned this pull request Jul 3, 2021
@@ -174,19 +174,6 @@ not a curated list of Julia packages. In particular this means that:
you install through the General registry -- you are responsible for reviewing your
code dependencies.

## Tips for registry maintainers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a pointer to RegistryCI docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, they are linked earlier in the automerge section, though that's kind of a different context. I'm not totally sure General is the right place though-- maybe the Pkg.jl docs on registries should be updated to mention RegistryCI (and probably LocalRegistry.jl too)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR to do that here: JuliaLang/Pkg.jl#2659

@DilumAluthge DilumAluthge merged commit d451c9a into master Jul 3, 2021
@DilumAluthge DilumAluthge deleted the eph/rm-readme-tips branch July 3, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants