New version: Static v0.6.3 #59357
Merged
New version: Static v0.6.3 #59357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuliaRegistrator
commented
Apr 29, 2022
JuliaRegistrator
commented
- Registering package: Static
- Repository: https://github.com/SciML/Static.jl
- Created by: @Tokazama
- Version: v0.6.3
- Commit: 7a9c792e7905adb49e2e6b1751d1ed577297317f
- Reviewed by: @Tokazama
- Reference: SciML/Static.jl@7a9c792#commitcomment-72490698
- Description: Static types useful for dispatch and generated functions.
UUID: aedffcd0-7271-4cad-89d0-dc628f76c6d3 Repo: https://github.com/SciML/Static.jl.git Tree: 91181e5820a400d1171db4382aa36e7fd19bee27 Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator
referenced
this pull request
in SciML/Static.jl
Apr 29, 2022
For Julia v1.6 this changes @time using Static from 0.054736 to 0.043993. For Julia v1.7 this changes @time using Static from 0.048681 to 0.038870. A lot of the improvement here is because redundant method definitions identified in the StaticInt PR to Base (e.g., Base.:(*)(::Zero, ::Zero)). As discussed in that PR, these are already known at compile time so explicitly defining them doesn't improve performance. I spent a pretty good amount of time with SnoopCompile and identified and simplified some method influence compile time. I tried generating a precompile file but it made start up time worse, so I'll have to look into that more later. This might be as good of an improvement as we can get while we still have invalidations in Base we can't resolve.
|
Your If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.