Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: TZJData v0.0.1+2023c #89129

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: dc5dba14-91b3-4cab-a142-028a31da12f7
Repo: https://github.com/JuliaTime/TZJData.jl.git
Tree: b32799596731e3d712cdf085b18a26f271ce110c

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
JuliaRegistrator referenced this pull request in JuliaTime/TZJData.jl Aug 6, 2023
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch August 6, 2023 05:24 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Version number is not allowed to contain build data

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@omus
Copy link
Contributor

omus commented Aug 6, 2023

[noblock] Expecting AutoMerge to fail here due to including build metadata in the version. I've added some details about this in https://github.com/JuliaTime/TZJData.jl#versioning. The gist is that the build metadata appears to be the best way inform interested users which tzdata version is being used (tzdata versions are incompatible with semver) while still utilizing semver correctly. In the future I'll attempt to add an exception in RegistryCI.jl for this package to avoid the AutoMerge headache but as of this moment it would be good to get this release in to validate that nothing else in the registry machinery is going go choke on a non-JLL build number.

@ViralBShah ViralBShah merged commit 4c68cc0 into master Aug 6, 2023
@ViralBShah ViralBShah deleted the registrator-tzjdata-dc5dba14-v0.0.1+2023c-29777bd64c branch August 6, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants