-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registering fails when you mention a tag #339
Comments
If we make a bare mirror clone of the upstream repo then we would get all of the branches, tags, etc. |
Even without that, it seems better to try and see if somethings works as a tag and if that fails then try it as a branch, rather than complicating the UI further. |
Thanks! |
Yes, bare seems sufficient. I can never remember what the difference is. |
This is after #335 was merged.
As pointed out in that PR we need the
origin/
prefix forgit rev-parse
so that we can get the tree SHA for non-default branches. It does not work however when we use a tag. For exampleorigin/v0.4
. So to solve this issue I think we should have two input fields one for Tag and another for Branch instead of having both in the same field. So now when we get a Tag we prefix withtags/
. For example,tags/v0.4
which works.The text was updated successfully, but these errors were encountered: