add Base.:(==) and Base.hash for AbstractEnv and test nash_conv on KuhnPokerEnv #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findmyway
requested changes
Jul 7, 2021
src/ReinforcementLearningEnvironments/src/environments/examples/examples.jl
Outdated
Show resolved
Hide resolved
findmyway
reviewed
Jul 7, 2021
| # checking the state of all players in env is enough? | ||
| """ | ||
| Base.:(==)(env1::T, env2::T) where T<:AbstractEnv | ||
| !!! warning: Only check the state of all players in the env. |
There was a problem hiding this comment.
Suggested change
| !!! warning: Only check the state of all players in the env. | |
| !!! warning | |
| Only check the state of all players in the env. |
This is the correct format for adding warning. Please read https://docs.julialang.org/en/v1/stdlib/Markdown/#Admonitions for more details.
findmyway
reviewed
Jul 7, 2021
findmyway
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Base.:(==) and Base.hash for AbstractEnv so that can compute nash_conv on KuhnPokerEnv().