Add a few convenience utilities #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main advantage these have is a small improvement in performance due to not needing to construct new objects. For Dicts of types, this switches to IdDict. This is both faster (particularly on construction), and safe for precompilation (see https://docs.julialang.org/en/latest/manual/modules/#Module-initialization-and-precompilation-1).
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 92.91% 92.92% +0.01%
==========================================
Files 26 27 +1
Lines 2836 2841 +5
==========================================
+ Hits 2635 2640 +5
Misses 201 201
Continue to review full report at Codecov.
|
|
This looks great, thanks for these improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main advantage these new predicates have is a small improvement in performance due to not needing to construct new objects for comparisons.
For Dicts of types, this switches to IdDict. This is both faster (particularly on construction), and safe for precompilation (see https://docs.julialang.org/en/latest/manual/modules/#Module-initialization-and-precompilation-1).