Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robustly use effect override internals #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Keno
Copy link
Contributor

@Keno Keno commented Nov 18, 2024

The effect override ABI is unstable. The current way it's being used is somewhat problematic: In release mode, it may silently stop working or apply the wrong effects and in debug mode it asserts. Instead, use the julia-level APIs, which have keyword arg constructors that are slightly more stable and will at least error consistently.

The effect override ABI is unstable. The current way it's being
used is somewhat problematic: In release mode, it may silently
stop working or apply the wrong effects and in debug mode it
asserts. Instead, use the julia-level APIs, which have keyword
arg constructors that are slightly more stable and will at least
error consistently.
@Keno
Copy link
Contributor Author

Keno commented Nov 18, 2024

@aviatesk

ERROR: LoadError: TypeError: in keyword argument nonoverlayed, expected UInt8, got a value of type Bool
Stacktrace:
   [1] concrete_eval_eligible
     @ ~/.julia/packages/JET/1ZQeA/src/analyzers/jetanalyzer.jl:287 [inlined]
   [2] abstract_call_method_with_const_args(interp::JET.JETAnalyzer{JET.BasicPass}, result::Core.Compiler.MethodCallResult, f::Any, arginfo::Core.Compiler.ArgInfo, si::Core.Compiler.StmtInfo, match::Core.MethodMatch, sv::Core.Compiler.InferenceState, invokecall::Nothing)

on CI, looks like it may be a JET issue?

Copy link

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which CI are you referring to? That error should be resolved in the latest version of JET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants