Reuse Nodes in Pools
#19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Apr 21, 2023
quinnj
reviewed
Apr 21, 2023
Co-authored-by: Jacob Quinn <[email protected]>
quinnj
reviewed
Apr 21, 2023
quinnj
reviewed
Apr 21, 2023
| @@ -57,13 +75,19 @@ function Base.acquire(f, pool::Pool{K, T}, key=nothing; forcenew::Bool=false, is | |||
| forcenew && return f() | |||
| # otherwise, check if there's an existing object in the pool to reuse | |||
| objs = Base.@lock pool.values get!(() -> ConcurrentStack{T}(), pool.values[], key) | |||
| obj = pop!(objs) | |||
| while obj !== nothing | |||
| prev_node = node = _popnode!(objs) | |||
quinnj
force-pushed
the
jq-pools
branch
2 times, most recently
from
fb01d42 to
24a00b8
Compare
|
Refactored the pool to not use concurrentstack: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea how to save us allocations for new node in
release.Pools now carry a vector ofNodes which can be reused.push!ing to aStacknow also accepts an emptyNodeas a new argument and we introduce a_popnode!operation that implementspop!for theStackand also yields a bufferedNodefrom thePool. This does seem to reduce allocations but is probably not faster (at least it doesn't seem to be from my small experiments)... Would be great to have a proper benchmark we care about to evaluate optimizations like this.