Allow for MKL v2025 and remove superfluous loading of libblas and libgomp under linux #103
Conversation
|
What do we bump here ? Patch version or minor version ? EDIT: I think due to @mipals remark in #104 it needs to be breaking as MKL drops 32bit support. So either it becomes 0.6, or, as I would prefer and we are breaking anyway, 1.0. Any comments on that ? |
- these now come prebaked in pardiso
|
@DmsPas can you confirm that Blas and openmp libs come bundeled with Pardiso if it is loaded via dlopen ? |
|
Yes, I can confirm that I confirm that for libpardiso.so in linux, BLAS and OpenMP are statically linked. |
j-fu
changed the title
|
Had another look - for me good to go... |
|
The CHANGELOG is a bit strange, I am not sure it is very useful for anyone. I think it is enough to just have a small note saying in perhaps the README saying that 1.0 dropped 32-bit support. |
- Remove everything before 0.5 - Keep the logs of the most important developments - Say what is breaking in 1.0
|
I would like to keep the changelog (stripped down now, agree that the autorgenerated stuff was too much). And I want to refer to the CHANGELOG.md in the (now mandatory) release notes for package registration for the breaking change. |
|
Looks good - but I am not a real user of Pardiso, so not up to date with the changes in MKL. |
This complements #2797463 wherein loading libblas and libgomp has been removed from the code as they are now distributed with the library (confirmed by upstream in #103 (comment))
No description provided.