Skip to content

Commit

Permalink
More adhereance to 1.10 error types (hopefully)
Browse files Browse the repository at this point in the history
  • Loading branch information
wsmoses committed Jan 9, 2025
1 parent 78035e1 commit 83e18eb
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions src/sparsevector.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1243,15 +1243,17 @@ function hvcat_internal(rows::Tuple{Vararg{Int}}, X1::_SparseConcatGroup, X::_Sp
if anysparse(X1) || anysparse(X...)
vcat(_hvcat_rows(rows, X1, X...)...)
else
# Needed to match error type with Base Julia. See https://github.com/JuliaLang/julia/pull/56543#issuecomment-2508637550
matrix_len = if length(rows) == 0
0
else
length(rows) * rows[1]
end
if matrix_len != 1 + length(X)
throw(ArgumentError("argument count does not match specified shape (expected $matrix_len, got $(1+length(X)))"))
end
if X1 <: Number && all(Base.Fix1(<:, Number), X)
# Needed to match error type with Base Julia. See https://github.com/JuliaLang/julia/pull/56543#issuecomment-2508637550
matrix_len = if length(rows) == 0
0
else
length(rows) * rows[1]
end
if matrix_len != 1 + length(X)
throw(ArgumentError("argument count does not match specified shape (expected $matrix_len, got $(1+length(X)))"))
end
end
Base.typed_hvcat(Base.promote_eltypeof(X1, X...), rows, X1, X...)
end
end
Expand Down

0 comments on commit 83e18eb

Please sign in to comment.