Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerness to avoid LazyArtifacts #444

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Eagerness to avoid LazyArtifacts #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99de99e
LazyArtifacts compat fix suggested by @staticfloat
palday Dec 2, 2020
b4e402c
avoid LazyArtifacts via eagerness
palday Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Artifacts.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# println("git-tree-sha1: ", Tar.tree_hash(IOBuffer(inflate_gzip(filename))))
# from https://julialang.github.io/Pkg.jl/dev/artifacts/
git-tree-sha1 = "75260d131b693f26e5834adf855f4c35d627348d"
lazy = true
lazy = false

[[TestData.download]]
# this is the SHA from https://osf.io/djaqb/download?version=4
Expand Down
8 changes: 8 additions & 0 deletions src/MixedModels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ using StatsBase
using StatsModels
using Tables

# When we move to 1.6 as the support lower minimum, we should change Artifact.toml to be lazy
# and add LazyArtifacts to our dependencies
# @static if VERSION > v"1.6.0-DEV.1588" # the actual bound may be lower
# @warn """Loading LazyArtifacts
# This will generate a dependency warning until compatibility with Julia 1.4+1.5 is removed"""
# using LazyArtifacts
# end

using LinearAlgebra: BlasFloat, BlasReal, HermOrSym, PosDefException, copytri!
using Base: Ryu
using GLM: Link, canonicallink
Expand Down