-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undo #634, return Table not DictTable #682
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 29 29
Lines 2732 2732
=======================================
Hits 2620 2620
Misses 112 112
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@palday I don't agree with the suggestion of the formatter bot but I suppose that if we ignore the suggestion it will just keep repeating it. Shall we follow its misguided directions? |
return Table( | ||
[NamedTuple{nms}((l, view(mat, :, i)...),) for (i, l) in enumerate(trm.levels)] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return Table( | |
[NamedTuple{nms}((l, view(mat, :, i)...),) for (i, l) in enumerate(trm.levels)] | |
) | |
nt = [NamedTuple{nms}((l, view(mat, :, i)...),) for (i, l) in enumerate(trm.levels)] | |
return Table(nt) |
@dmbates woops I missed your comment before accepting the bot's suggestion. I've made an alternative suggestion that will hopefully appease the bot and still be legible. |
@JuliaRegistrator register |
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
TypedTables.Table
not aDictTable
inraneftables
. Manipulation of aDictTable
becomes too awkward for anything other than extracting a row by key.Did behavior change? Did you add need features? If so, please update NEWS.md
docs/NEWS-update.jl
to update the cross-references.Should we release your changes right away? If so, bump the version: