Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to find better starting values for GLMM when defaults aren't positive semidefinite #796

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

palday
Copy link
Member

@palday palday commented Dec 10, 2024

closes #792

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (7103ee1) to head (ffdf318).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
+ Coverage   97.08%   97.12%   +0.03%     
==========================================
  Files          33       33              
  Lines        3401     3405       +4     
==========================================
+ Hits         3302     3307       +5     
+ Misses         99       98       -1     
Flag Coverage Δ
current 96.82% <100.00%> (+0.03%) ⬆️
minimum 97.06% <100.00%> (+0.03%) ⬆️
nightly 96.75% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On reading the section of src/generalizedlinearmixedmodel.jl that is modified it seems that a lot of work is being done to handle the case of constresponse. From the comments it seems that the reason for handling constresponse is for convenience in starting simulations. Is that correct? Would it be better to just error on constresponse with a message to come up with more realistic starting values?

@dmbates
Copy link
Collaborator

dmbates commented Dec 11, 2024

I see that I misread the code. You only try the fix-up if constresponse is false. Never mind.

@palday palday merged commit f7b2017 into main Dec 11, 2024
12 checks passed
@palday palday deleted the pa/issue792 branch December 11, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-positive definite matrix when fitting nested GLMM
2 participants