-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to find better starting values for GLMM when defaults aren't positive semidefinite #796
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 97.08% 97.12% +0.03%
==========================================
Files 33 33
Lines 3401 3405 +4
==========================================
+ Hits 3302 3307 +5
+ Misses 99 98 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On reading the section of src/generalizedlinearmixedmodel.jl
that is modified it seems that a lot of work is being done to handle the case of constresponse
. From the comments it seems that the reason for handling constresponse
is for convenience in starting simulations. Is that correct? Would it be better to just error on constresponse
with a message to come up with more realistic starting values?
I see that I misread the code. You only try the fix-up if |
closes #792
docs/NEWS-update.jl
to update the cross-references.