Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.0+ compatibility #12

Closed
wants to merge 8 commits into from
Closed

Conversation

hhaensel
Copy link
Contributor

@hhaensel hhaensel commented Dec 5, 2019

From version 1.0.0 on the compatibility functions start(), next() and done() for iterables were removed.
As this module only uses these functions with respect to strings, re-adding the functions is a three-liner. All tests pass under 1.0.0 and 1.3.0 (tested under Windows 10).

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.03%) to 97.462% when pulling 193286c on hhaensel:master into b96e0b0 on JuliaString:master.

@coveralls
Copy link

coveralls commented Dec 5, 2019

Coverage Status

Coverage increased (+0.07%) to 99.561% when pulling b3a2ca2 on hhaensel:master into b96e0b0 on JuliaString:master.

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #12 into master will decrease coverage by 0.54%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   99.48%   98.94%   -0.55%     
==========================================
  Files           1        1              
  Lines         196      190       -6     
==========================================
- Hits          195      188       -7     
- Misses          1        2       +1
Impacted Files Coverage Δ
src/StringLiterals.jl 98.94% <100%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96e0b0...933ea2e. Read the comment docs.

@hhaensel hhaensel force-pushed the master branch 2 times, most recently from 4448ab4 to 182b889 Compare December 9, 2019 12:26
@hhaensel
Copy link
Contributor Author

hhaensel commented Dec 9, 2019

I learned a lot about Travis and the package manager (sorry for the many commits 😉 )
What I changed:

  • created a Project.toml and made StringLaterals version 1.0.0-DEV
  • adapted Travis to test with the inline=no option in order to get around the missing lines issue in Coverage.jl.

This version runs on all OSes on Julia versions from 0.6 to nightly.
I hope, this could be a version to be again registered with the Julia repositories.

@hhaensel
Copy link
Contributor Author

I'll close this PR and open a new one with less commits 😉

@hhaensel hhaensel closed this Dec 10, 2019
@ScottPJones
Copy link
Member

I'm sorry I missed this (been busy with personal issues lately, unfortunately).
You didn't need to close the PR and open a new one, just learn how to squash your commits with git in the future (and I hope to see more PRs from you, especially if you can move to the Strs set of packages 😄
I have merged the new PR, even though I hadn't intended on making any more changes to StringLiterals, as it as been completely superseded by StrLiterals (with StrFormat & StrEntities)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants