-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia 1.0+ compatibility #12
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 99.48% 98.94% -0.55%
==========================================
Files 1 1
Lines 196 190 -6
==========================================
- Hits 195 188 -7
- Misses 1 2 +1
Continue to review full report at Codecov.
|
- include windows - add `using Pkg`
4448ab4
to
182b889
Compare
I learned a lot about Travis and the package manager (sorry for the many commits 😉 )
This version runs on all OSes on Julia versions from 0.6 to nightly. |
I'll close this PR and open a new one with less commits 😉 |
I'm sorry I missed this (been busy with personal issues lately, unfortunately). |
From version 1.0.0 on the compatibility functions
start()
,next()
anddone()
for iterables were removed.As this module only uses these functions with respect to strings, re-adding the functions is a three-liner. All tests pass under 1.0.0 and 1.3.0 (tested under Windows 10).