-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use datadeps for AvgPerceptronTagger, add pos tagging over document types #166
Conversation
Thanks for the review, I will make the changes ASAP. |
@aviks I have made the suggested changes. I also provided Please review this (since there will be some merge conflicts with #167_Comment ) |
As of now, the AvgPerceptronTagger is taking the weights from the git version control history (link). It may be neater to release the file as an asset on GitHub (similar to MetalHead.jl). Also, various other NLP libraries like SpaCy use avg perceptron tagger from POS. Maybe the model weights from these libraries along with one we currently provide could be tested, and then the best one could be made available from this package. Once this is done, we can release the weights. |
I have added the file (zipped) into a release on this package. https://github.com/JuliaText/TextAnalysis.jl/releases/download/v0.6.0/pretrainedMod.bson.zip |
I have changed the link to the Perceptrony Tagger weights. |
I have switched to using datadeps instead of storing weights locally, similar to the NER API.
As of now, I am directly taking it from version control history, but perhaps it could be released as an asset.