Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named Entity Recognition #167
Named Entity Recognition #167
Changes from 10 commits
2d27a95
e18d0f9
5730d5d
3d88d26
ebff0cf
88541b7
49aea7c
e29dc7d
53e8eec
24c8a03
5d572f5
6d5dcc9
c2567b4
1051ac8
90d334a
a3792ec
bfc738f
ab62d3b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does
.xz
files work on windows?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get what you mean by work on windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean how to extract/unzip the file, I think
WinRar
should let you extract it.Or if you are referring to the file being unpacked, then
DataDeps
package functionunpack
handles it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant will DataDeps be able to unzip the file without the user having to install additional things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work - DataDeps.jl has a test for checking the
unpack
for tarballs. In this line - https://github.com/oxinabox/DataDeps.jl/blob/12bf837dc4ba09edca19fe617d1408ec7dae1796/test/examples.jl#L137There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
Windows
to the os in travis CI and sent a PR to my own fork ofDataDeps.jl
. The tests were ran onlinux
,mac osz
andwindows
and passed on all the os - Ayushk4/DataDeps.jl#1