Allow access to the artifact path in a relocatable way #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
reviewed
Oct 31, 2024
|
Should a issue or a PR be made to inform uses of |
omus
reviewed
Oct 31, 2024
Co-authored-by: Curtis Vogt <[email protected]>
|
I applied the suggested changes and added a precompilation statement (it's not really making things faster, but it's not going to hurt). |
omus
reviewed
Nov 4, 2024
Co-authored-by: Curtis Vogt <[email protected]>
omus
approved these changes
Dec 20, 2024
|
Thank you @omus and @lcontento! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of a possible solution to JuliaTime/TimeZones.jl#467. The other half is at JuliaTime/TimeZones.jl#479.
Allows accessing the correct artifact path even if the depot has been relocated (e.g. when including the package in a system image).
In theory
artifact_dir()should always be preferred toARTIFACT_DIRfor the above reason, so one would ideally removeARTIFACT_DIRall together. That would be a breaking change though.