Rework VTK extents for structured grids #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies and slightly modifies the behaviour of the
extent
keyword argument for structured grids:extent
can no longer be given as a 6-element array[x1, x2, y1, y2, z1, z2]
. Instead, it should be passed as a tuple of ranges:(x1:x2, y1:y2, z1:z2)
.x1 = y1 = z1 = 1
by default. These are transformed to zero-based when writing to VTK.extent
is now taken into account for shifting the origin from the input coordinates.Note that
extent
is undocumented, and in principle only to be used internally to write parallel formats (#98). Therefore this is not really considered a breaking change.