Possible fix to BRAM uint0_t size issue... #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Rounding" 0 to 1 by adding extra 1...
Possible fix to uint0_t RAM function
| @@ -1756,7 +1756,7 @@ def GET_MEM_H_LOGIC_LOOKUP(parser_state): | |||
| dim = dims[i] | |||
| addr_t = ( | |||
| "uint" | |||
| + str(int(math.ceil(math.log(dim, 2)))) | |||
| + str(int(math.ceil(math.log(dim, 2)))+1) #round up by 1 | |||
There was a problem hiding this comment.
Reasonable, but I prefer to keep the width exact as needed
For ex. you need two address bits to address four things
but the round up by one makes it 3 bits for dim=4
hmm maybe just need a simple 'its uint1 unless >1 then do math as is'
There was a problem hiding this comment.
There is another place this math occurs at for sizing muxes in this same file
Line 2060 in bf7e57f
mind changing there too?
And searching repo I found one more place
Line 2307 in bf7e57f
could maybe make a common helper func in https://github.com/JulianKemmerer/PipelineC/blob/master/src/utilities.py
but not critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just rounding up the result from log2