-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for attributes from FabricSettings{}
in resource apstra_datacenter_blueprint
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
changed the title
WIP: Introduce support for attributes from
Introduce support for attributes from Mar 5, 2024
FabricSettings{}
in resource apstra_datacenter_blueprint
FabricSettings{}
in resource apstra_datacenter_blueprint
…o `Blueprint.fabricSettingsNeedsUpdate()`
chrismarget-j
force-pushed
the
fabric-settings
branch
from
March 5, 2024 17:11
b721ba6
to
7035464
Compare
bwJuniper
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long road but we got here!
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of recent SDK work:
GetFabricSettings()
,SetFabricSettings()
and the inclusion of aFabricSettings{}
struct in theCreateBlueprintFromTemplate{}
struct.The
apstra_datacenter_blueprint
data source and resource now support the following additional attributes:anti_affinity_mode
anti_affinity_policy
default_ip_links_to_generic_mtu
default_svi_l3_mtu
esi_mac_msb
evpn_type_5_routes
fabric_mtu
ipv6_applications
junos_evpn_max_nexthop_and_interface_number
junos_evpn_routing_instance_mode_mac_vrf
junos_ex_overlay_ecmp
junos_graceful_restart
max_evpn_routes_count
max_external_routes_count
max_fabric_routes_count
max_mlag_routes_count
optimize_routing_zone_footprint
Tested/working with the following Apstra versions: