This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Handle key and secret permissions errors #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2023 11:09
Gonzalo-Avalos-Ribas
added
patch
zemberdotnet
reviewed
Dec 5, 2023
Comment on lines
+68
to
+71
| this.logger.publishWarnEvent({ | ||
| name: IntegrationWarnEventName.MissingEntity, | ||
| description: `This tenant/application is not allowed to access keys for vault ${vaultUri}`, | ||
| }); |
There was a problem hiding this comment.
If line 44 throws, does it continue the loop or does it end the loop? Are we skipping just one or ending the whole step?
There was a problem hiding this comment.
It's ending the loop ! we are skipping all the keys or secrets for that keyvault.
But we continue iterating other vaults
There was a problem hiding this comment.
I see. So this logs message only prints once. LGTM 👍
zemberdotnet
approved these changes
Dec 5, 2023
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"RestError: AKV10032: Invalid issuer. Expected one of https://sts.windows.net/5ae1af62-9505-4097-a69a-c1553ef7840e/, https://sts.windows.net/f8cdef31-a31e-4b4a-93e4-5f571e91255a/, https://sts.windows.net/e2d54eb5-3869-4f70-8578-dee5fc7331f4/, found https://sts.windows.net/e5385570-36f1-4d50-aaf8-db2f87aa884a/. \n[...]"
We are requesting the keys with the wrong tenant/application. All of our integrations are single tenant based, so it would be impossible to ingest!