Jamf enhancement dev #160
Jamf enhancement dev #160
Conversation
CHANGELOG.md
Outdated
|
|
||
| #### 🐛 Bug Fix | ||
|
|
||
| - Updated the code device group entity : missing groups |
There was a problem hiding this comment.
Updated the code for Device Group Entity
There was a problem hiding this comment.
@Bharatkk-metron Please make this change
| if (computerIdSet.has(computerDevice.id)) { | ||
| continue; | ||
| } | ||
| computerIdSet.add(computerDevice.id); |
There was a problem hiding this comment.
Why are we doing this? Is there a chance that computerDevice will have duplicate values in computerDevices?
There was a problem hiding this comment.
For a larger data set, this might be the case. In the previous code, they were checking for duplications therefore putting a check to avoid duplicate key errors.
CHANGELOG.md
Outdated
|
|
||
| #### 🐛 Bug Fix | ||
|
|
||
| - Updated the code device group entity : missing groups |
There was a problem hiding this comment.
@Bharatkk-metron Please make this change
|
@poornima-metron - On future PRs, please reference the Jira ticket or SOW associated with this work. Thanks! |
Co-authored-by: Samuel Poulton <[email protected]>
Co-authored-by: Samuel Poulton <[email protected]>
|
I think this PR is ready to be merged once the Build/test check is passing. |
fixed review comments
|
These changes need to be moved here. Closing this PR now. |
Description
Thank you for contributing to a JupiterOne integration!
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.
Summary
Type of change
Please leave any irrelevant options unchecked.
not work as expected)
Checklist
General Development Checklist:
Integration Development Checklist:
Please leave any irrelevant options unchecked.
endpoints, and have documented any additional permissions in
jupiterone.md, where necessary.API
using
dependsOnJupiterOne data model
to ensure that any new entities/relationships, and relevant properties,
match the recommended model for this class of data
CHANGELOG.mdfile to describe my changesreviewed all existing managed questions referencing the entities,
relationships, and their property names, to ensure those questions still
function with my changes.