Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Initial integration #1

Merged
merged 11 commits into from
May 21, 2020
Merged

Initial integration #1

merged 11 commits into from
May 21, 2020

Conversation

erkangz
Copy link
Contributor

@erkangz erkangz commented May 19, 2020

No description provided.

@erkangz erkangz requested review from aiwilliams and philidem May 19, 2020 23:10
aiwilliams
aiwilliams previously approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@aiwilliams aiwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be necessary to git tag v0.1.0 if you'd like the merge to master to publish.

docs/jupiterone.md Outdated Show resolved Hide resolved
src/collector/types.ts Show resolved Hide resolved
src/collector/ServicesClient.ts Show resolved Hide resolved
src/validateInvocation.ts Outdated Show resolved Hide resolved
src/validateInvocation.ts Outdated Show resolved Hide resolved
aiwilliams
aiwilliams previously approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@aiwilliams aiwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember if I pointed this out already... You'll want to git tag v0.1.0 and then git push --tags so that when this is merged, it will get published.

@erkangz erkangz merged commit 8f82bf3 into master May 21, 2020
@erkangz erkangz deleted the init branch May 21, 2020 19:19
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v2.1.0 🚀

@j1-internal-automation j1-internal-automation added the released This issue/pull request has been released. label Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aiwilliams aiwilliams aiwilliams approved these changes

@philidem philidem Awaiting requested review from philidem

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erkangz @j1-internal-automation @aiwilliams