This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
change userId to be string. remove broken mrr. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemberdotnet
commented
Jul 3, 2024
| id: user.id, | ||
| userId: user.userId as number, | ||
| username: user.username as number, | ||
| email: user.userId as number, |
There was a problem hiding this comment.
The email isn't a number...
jzolo22
approved these changes
Jul 8, 2024
|
From the Slack conversation, it sounds like we might be able to remove the Person entity altogether here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
userId should be a string. If you can't add, subtract, multiply, and divide, then it's not a number 😃
I also removed a mapped relationship that has surely never been created. The property
emailpointed to theuserIdwhich is a number...