Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schema optional in toMatchGraphObjectSchema #333

Closed
ndowmon opened this issue Sep 10, 2020 · 0 comments · Fixed by #334
Closed

Make schema optional in toMatchGraphObjectSchema #333

ndowmon opened this issue Sep 10, 2020 · 0 comments · Fixed by #334

Comments

@ndowmon
Copy link
Contributor

ndowmon commented Sep 10, 2020 •
edited by austinkelleher
Loading

When developers don't provide additional schema to toMatchGraphObjectSchema, the interface can confuse developers or reviewers:

expect(result).toMatchGraphObjectSchema({
  _class: ['DomainZone'],
  schema: {},
});

Making schema optional will remove some ambiguity from above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #333 & #296: Jest matcher optional schema JupiterOne/sdk
1 participant
@ndowmon