Automatically include _rawData in schema for entities #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i5o
previously approved these changes
Jan 12, 2024
Comment on lines
612
to
615
| const data = { | ||
| ...received[i], | ||
| }; | ||
| delete data._rawData; |
There was a problem hiding this comment.
const {
_rawData,
...data
} = received[i];Can we do this to not mutate the object?
There was a problem hiding this comment.
Oh I guess it is a copy of the object. Should be fine then.
There was a problem hiding this comment.
Yeah it would have only removed it from data since it was a shallow copy
Nick-NCSU
changed the title
zemberdotnet
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when validating graph object's schema with
additionalProperties: falseyou are required to add _rawData as a property (As seen here)This will remove automatically add the property to the schema to prevent this need.