Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #284 - Add jobState.findEntity function #304

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Fixes #284 - Add jobState.findEntity function #304

merged 3 commits into from
Aug 24, 2020

Conversation

austinkelleher
Copy link
Contributor

I must have messed up a rebase previously. For some reason this code isn't in master...RIP

I cherry-picked the previous commits.

ndowmon
ndowmon approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@ndowmon ndowmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the behavior of findEntity replaces the need for getEntity which I actually implemented with a sort of confusing interface (throwing for undefined). Should we consider deprecating the latter?

@austinkelleher austinkelleher merged commit 5cf43d9 into master Aug 24, 2020
@austinkelleher austinkelleher deleted the 284-jobState-findEntity branch August 24, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndowmon ndowmon ndowmon approved these changes

@aiwilliams aiwilliams Awaiting requested review from aiwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinkelleher @ndowmon