Fixes #301 - Register inputEntities & inputRelationships in mockJobState

[ndowmon]

No description provided.

[aiwilliams]

How do you feel about moving this logic below the const ... function declarations, just before the return ...:

addEntities(inputEntities);
addRelationships(inputRelationships);

I might be missing a finer detail 😄

[ndowmon]

@aiwilliams the addEntities and addRelationships functions also push graph objects onto the collected<GraphObjects> list. That breaks tests since collected<GraphObjects> should only contain graph objects that were added during the step.

I could alternatively refactor a bit to something like this:

const addEntitiesToDuplicateKeyTracker = (newEntities: Entity[]) => {
  newEntities.forEach((e) => {
    duplicateKeyTracker.registerKey(e._key, {
      _type: e._type,
    });
    typeTracker.registerType(e._type);
  });
};
addEntitiesToDuplicateKeyTracker(inputEntities);

const addEntities = async (newEntities: Entity[]): Promise<Entity[]> => {
  addEntitiesToDuplicateKeyTracker(newEntities);
  collectedEntities = collectedEntities.concat(newEntities);
  return Promise.resolve(newEntities);
}

const addRelationshipsToDuplicateKeyTracker = (newRelationships: Relationship[]) => {
  newRelationships.forEach((r) => {
    duplicateKeyTracker.registerKey(r._key as string, {
      _type: r._type,
    });
    typeTracker.registerType(r._type as string);
  });
};
addRelationshipsToDuplicateKeyTracker(inputRelationships);

const addRelationships = async (newRelationships: Relationship[]) => {
  addRelationshipsToDuplicateKeyTracker(newRelationships);
  collectedRelationships = collectedRelationships.concat(newRelationships);
  return Promise.resolve();
};

const iterateEntities = async <T extends Entity = Entity>(
  filter,
  iteratee,
) => {
  const filteredEntities = [...inputEntities, ...collectedEntities].filter(
    (e) => e._type === filter._type,
  );
  for (const entity of filteredEntities as T[]) {
    await iteratee(entity);
  }
};

It removes duplicate code which may be worth the change, but it's still not particularly attractive.

[aiwilliams]

Thanks for clarifying for me!