Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AutoSteamSaleEvent farming preference #3360

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Remove AutoSteamSaleEvent farming preference #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ArchiSteamFarm/Localization/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,14 +551,6 @@ StackTrace:
Process uptime: {1}</value>
<comment>{0} will be replaced by number (in megabytes) of memory being used, {1} will be replaced by translated TimeSpan string (such as "25 minutes"). Please note that this string should include newlines for formatting.</comment>
</data>
<data name="ClearingDiscoveryQueue" xml:space="preserve">
<value>Clearing Steam discovery queue #{0}...</value>
<comment>{0} will be replaced by queue number</comment>
</data>
<data name="DoneClearingDiscoveryQueue" xml:space="preserve">
<value>Done clearing Steam discovery queue #{0}.</value>
<comment>{0} will be replaced by queue number</comment>
</data>
<data name="BotOwnsOverviewPerGame" xml:space="preserve">
<value>{0}/{1} bots already own game {2}.</value>
<comment>{0} will be replaced by number of bots that already own particular game being checked, {1} will be replaced by total number of bots that were checked during the process, {2} will be replaced by game's ID (number)</comment>
Expand Down
16 changes: 0 additions & 16 deletions ArchiSteamFarm/Steam/Bot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@

namespace ArchiSteamFarm.Steam;

public sealed class Bot : IAsyncDisposable, IDisposable {

Check warning on line 66 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
internal const ushort CallbackSleep = 500; // In milliseconds
internal const byte MinCardsPerBadge = 5;

Expand Down Expand Up @@ -314,7 +314,6 @@
private bool SendCompleteTypesScheduled;
private Timer? SendItemsTimer;
private bool SteamParentalActive;
private SteamSaleEvent? SteamSaleEvent;
private Timer? TradeCheckTimer;
private string? TwoFactorCode;
private bool UnpackBoosterPacksScheduled;
Expand Down Expand Up @@ -366,7 +365,7 @@
Directory.CreateDirectory(debugListenerPath);

SteamClient.DebugNetworkListener = new NetHookNetworkListener(debugListenerPath, SteamClient);
} catch (Exception e) {

Check warning on line 368 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify '.ctor' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);
}
}
Expand Down Expand Up @@ -427,7 +426,6 @@
PlayingWasBlockedTimer?.Dispose();
RefreshTokensTimer?.Dispose();
SendItemsTimer?.Dispose();
SteamSaleEvent?.Dispose();
TradeCheckTimer?.Dispose();
}

Expand Down Expand Up @@ -465,10 +463,6 @@
await SendItemsTimer.DisposeAsync().ConfigureAwait(false);
}

if (SteamSaleEvent != null) {
await SteamSaleEvent.DisposeAsync().ConfigureAwait(false);
}

if (TradeCheckTimer != null) {
await TradeCheckTimer.DisposeAsync().ConfigureAwait(false);
}
Expand All @@ -481,7 +475,7 @@
foreach (string filePath in RelatedFiles.Select(static file => file.FilePath).Where(File.Exists)) {
try {
File.Delete(filePath);
} catch (Exception e) {

Check warning on line 478 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'DeleteAllRelatedFiles' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);

return false;
Expand Down Expand Up @@ -1079,7 +1073,7 @@
if (File.Exists(unusedKeysFilePath)) {
try {
File.Delete(unusedKeysFilePath);
} catch (Exception e) {

Check warning on line 1076 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'DeleteRedeemedKeysFiles' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);

return false;
Expand All @@ -1097,7 +1091,7 @@
if (File.Exists(usedKeysFilePath)) {
try {
File.Delete(usedKeysFilePath);
} catch (Exception e) {

Check warning on line 1094 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'DeleteRedeemedKeysFiles' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);

return false;
Expand Down Expand Up @@ -1201,7 +1195,7 @@
for (byte i = 0; (i < WebBrowser.MaxTries) && (tokenCallback == null) && IsConnectedAndLoggedOn; i++) {
try {
tokenCallback = await SteamApps.PICSGetAccessTokens(appID, null).ToLongRunningTask().ConfigureAwait(false);
} catch (Exception e) {

Check warning on line 1198 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'GetAppDataForIdling' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericWarningException(e);
}
}
Expand All @@ -1217,7 +1211,7 @@
for (byte i = 0; (i < WebBrowser.MaxTries) && (productInfoResultSet == null) && IsConnectedAndLoggedOn; i++) {
try {
productInfoResultSet = await SteamApps.PICSGetProductInfo(request.ToEnumerable(), []).ToLongRunningTask().ConfigureAwait(false);
} catch (Exception e) {

Check warning on line 1214 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'GetAppDataForIdling' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericWarningException(e);
}
}
Expand Down Expand Up @@ -1355,7 +1349,7 @@
for (byte i = 0; (i < WebBrowser.MaxTries) && (productInfoResultSet == null) && IsConnectedAndLoggedOn; i++) {
try {
productInfoResultSet = await SteamApps.PICSGetProductInfo([], packageRequests).ToLongRunningTask().ConfigureAwait(false);
} catch (Exception e) {

Check warning on line 1352 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'GetPackagesData' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericWarningException(e);
}
}
Expand Down Expand Up @@ -1511,7 +1505,7 @@
}

File.Delete(filePath);
} catch (Exception e) {

Check warning on line 1508 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'ImportKeysToRedeem' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);
}
}
Expand Down Expand Up @@ -1648,7 +1642,7 @@

try {
response = await SteamClient.Authentication.GenerateAccessTokenForAppAsync(SteamID, RefreshToken, true).ConfigureAwait(false);
} catch (Exception e) {

Check warning on line 1645 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'RefreshWebSession' to catch a more specific allowed exception type, or rethrow the exception
// The request has failed, in almost all cases this means our refresh token is no longer valid, relog needed
ArchiLogger.LogGenericWarningException(e);

Expand Down Expand Up @@ -1830,8 +1824,8 @@
}

try {
File.Move(filePath, newFilePath);

Check warning on line 1827 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Review code for file path injection vulnerabilities 

Potential file path injection vulnerability was found where 'void File.Move(string sourceFileName, string destFileName)' in method 'Task Bot.Rename(string newBotName)' may be tainted by user-controlled data from 'BotRenameRequest request' in method 'Task\> BotController.RenamePost(string botName, BotRenameRequest request)'.
} catch (Exception e) {

Check warning on line 1828 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'Rename' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);

return false;
Expand Down Expand Up @@ -2080,7 +2074,7 @@

try {
await callbacksAborted.CancelAsync().ConfigureAwait(false);
} catch {

Check warning on line 2077 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'Destroy' to catch a more specific allowed exception type, or rethrow the exception
// Ignored, object already disposed or similar
}
}
Expand Down Expand Up @@ -2149,7 +2143,7 @@
string name = parsedArgs[0];
keys[key] = name;
}
} catch (Exception e) {

Check warning on line 2146 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'GetKeysFromFile' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);

return null;
Expand Down Expand Up @@ -2340,7 +2334,7 @@
}

HeartBeatFailures = 0;
} catch (Exception e) {

Check warning on line 2337 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'HeartBeat' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericDebuggingException(e);

if (!KeepRunning || !IsConnectedAndLoggedOn || (HeartBeatFailures == byte.MaxValue)) {
Expand Down Expand Up @@ -2385,7 +2379,7 @@
}

File.Delete(maFilePath);
} catch (Exception e) {

Check warning on line 2382 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'ImportAuthenticatorFromFile' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);
}
}
Expand Down Expand Up @@ -2504,12 +2498,6 @@
SendItemsTimer = null;
}

if (SteamSaleEvent != null) {
await SteamSaleEvent.DisposeAsync().ConfigureAwait(false);

SteamSaleEvent = null;
}

if (TradeCheckTimer != null) {
await TradeCheckTimer.DisposeAsync().ConfigureAwait(false);

Expand All @@ -2525,10 +2513,6 @@
);
}

if (BotConfig.FarmingPreferences.HasFlag(BotConfig.EFarmingPreferences.AutoSteamSaleEvent)) {
SteamSaleEvent = new SteamSaleEvent(this);
}

if (BotConfig.TradeCheckPeriod > 0) {
TradeCheckTimer = new Timer(
OnTradeCheckTimer,
Expand Down Expand Up @@ -3675,7 +3659,7 @@

try {
await File.AppendAllTextAsync(filePath, $"{logEntry}{Environment.NewLine}").ConfigureAwait(false);
} catch (Exception e) {

Check warning on line 3662 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'RedeemGamesInBackground' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);
ArchiLogger.LogGenericError(Strings.FormatContent(logEntry));

Expand Down Expand Up @@ -3778,7 +3762,7 @@
ArchiLogger.LogGenericWarningException(e);

return;
} catch (Exception e) {

Check warning on line 3765 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'SendCompletedSets' to catch a more specific allowed exception type, or rethrow the exception
ArchiLogger.LogGenericException(e);

return;
Expand Down Expand Up @@ -4079,7 +4063,7 @@
return (true, steamParentalCode);
}

public enum EFileType : byte {

Check warning on line 4066 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of EFileType System.Int32 instead of byte

Check warning on line 4066 in ArchiSteamFarm/Steam/Bot.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
Config,
Database,
KeysToRedeem,
Expand Down
39 changes: 0 additions & 39 deletions ArchiSteamFarm/Steam/Data/NewDiscoveryQueueResponse.cs
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

namespace ArchiSteamFarm.Steam.Integration;

public sealed class ArchiWebHandler : IDisposable {

Check warning on line 53 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
// Steam network (ArchiHandler) works unstable with more items than this (throwing upon description details), while Steam web (ArchiWebHandler) silently limits to this value maximum
internal const ushort MaxItemsInSingleInventoryRequest = 5000;

Expand Down Expand Up @@ -167,7 +167,7 @@

try {
result = json.ToJsonObject<ImmutableHashSet<BoosterCreatorEntry>>();
} catch (Exception e) {

Check warning on line 170 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'GetBoosterCreatorEntries' to catch a more specific allowed exception type, or rethrow the exception
Bot.ArchiLogger.LogGenericException(e);

return null;
Expand Down Expand Up @@ -749,7 +749,7 @@
Bot.ArchiLogger.LogGenericWarning(Strings.WarningFailed);
Bot.ArchiLogger.LogGenericDebug(Strings.FormatErrorFailingRequest(request));

return default(ObjectResponse<T>?);

Check notice on line 752 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

Prefer using concrete value over 'default' or 'new()' 

Use 'null' instead of 'default(T)'
}
}

Expand All @@ -759,7 +759,7 @@
ObjectResponse<T>? response = await WebLimitRequest(host, async () => await WebBrowser.UrlGetToJsonObject<T>(request, headers, referer, requestOptions, maxTries, rateLimitingDelay, cancellationToken).ConfigureAwait(false), cancellationToken).ConfigureAwait(false);

if (response == null) {
return default(ObjectResponse<T>?);

Check notice on line 762 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

Prefer using concrete value over 'default' or 'new()' 

Use 'null' instead of 'default(T)'
}

if (IsSessionExpiredUri(response.FinalUri)) {
Expand Down Expand Up @@ -1480,7 +1480,7 @@

return (result, EPurchaseResultDetail.ContactSupport);
}
} catch (Exception e) {

Check warning on line 1483 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'AddFreeLicense' to catch a more specific allowed exception type, or rethrow the exception
Bot.ArchiLogger.LogGenericException(e);

return (result, EPurchaseResultDetail.ContactSupport);
Expand Down Expand Up @@ -1530,17 +1530,6 @@
return true;
}

internal async Task<bool> ClearFromDiscoveryQueue(uint appID) {
ArgumentOutOfRangeException.ThrowIfZero(appID);

Uri request = new(SteamStoreURL, $"/app/{appID}");

// Extra entry for sessionID
Dictionary<string, string> data = new(2, StringComparer.Ordinal) { { "appid_to_clear_from_queue", appID.ToString(CultureInfo.InvariantCulture) } };

return await UrlPostWithSession(request, data: data).ConfigureAwait(false);
}

internal async Task<bool> DeclineTradeOffer(ulong tradeID) {
ArgumentOutOfRangeException.ThrowIfZero(tradeID);

Expand All @@ -1551,17 +1540,6 @@

internal HttpClient GenerateDisposableHttpClient() => WebBrowser.GenerateDisposableHttpClient();

internal async Task<ImmutableHashSet<uint>?> GenerateNewDiscoveryQueue() {
Uri request = new(SteamStoreURL, "/explore/generatenewdiscoveryqueue");

// Extra entry for sessionID
Dictionary<string, string> data = new(2, StringComparer.Ordinal) { { "queuetype", "0" } };

ObjectResponse<NewDiscoveryQueueResponse>? response = await UrlPostToJsonObjectWithSession<NewDiscoveryQueueResponse>(request, data: data).ConfigureAwait(false);

return response?.Content?.Queue;
}

internal async Task<HashSet<uint>?> GetAppList() {
KeyValue? response = null;

Expand All @@ -1583,7 +1561,7 @@
).ConfigureAwait(false);
} catch (TaskCanceledException e) {
Bot.ArchiLogger.LogGenericDebuggingException(e);
} catch (Exception e) {

Check warning on line 1564 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'GetAppList' to catch a more specific allowed exception type, or rethrow the exception
Bot.ArchiLogger.LogGenericWarningException(e);
}
}
Expand Down Expand Up @@ -1698,7 +1676,7 @@
).ConfigureAwait(false);
} catch (TaskCanceledException e) {
Bot.ArchiLogger.LogGenericDebuggingException(e);
} catch (Exception e) {

Check warning on line 1679 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'GetCombinedTradeHoldDurationAgainstUser' to catch a more specific allowed exception type, or rethrow the exception
Bot.ArchiLogger.LogGenericWarningException(e);
}
}
Expand Down Expand Up @@ -1793,14 +1771,6 @@
return results;
}

internal async Task<IDocument?> GetDiscoveryQueuePage() {
Uri request = new(SteamStoreURL, "/explore?l=english");

HtmlDocumentResponse? response = await UrlGetToHtmlDocumentWithSession(request, checkSessionPreemptively: false).ConfigureAwait(false);

return response?.Content;
}

internal async Task<HashSet<ulong>?> GetFamilySharingSteamIDs() {
Uri request = new(SteamStoreURL, "/account/managedevices?l=english");

Expand Down Expand Up @@ -2324,7 +2294,7 @@
return true;
}

public enum ESession : byte {

Check warning on line 2297 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of ESession System.Int32 instead of byte

Check warning on line 2297 in ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None,
Lowercase,
CamelCase,
Expand Down
121 changes: 0 additions & 121 deletions ArchiSteamFarm/Steam/Integration/SteamSaleEvent.cs
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions ArchiSteamFarm/Steam/Storage/BotConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
namespace ArchiSteamFarm.Steam.Storage;

[SuppressMessage("ReSharper", "ClassCannotBeInstantiated")]
public sealed class BotConfig {

Check warning on line 49 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
[PublicAPI]
public const bool DefaultAcceptGifts = false;

Expand Down Expand Up @@ -554,7 +554,7 @@
}

botConfig = json.ToJsonObject<BotConfig>();
} catch (Exception e) {

Check warning on line 557 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Do not catch general exception types 

Modify 'Load' to catch a more specific allowed exception type, or rethrow the exception
ASF.ArchiLogger.LogGenericException(e);

return (null, null);
Expand Down Expand Up @@ -599,7 +599,7 @@
}

[PublicAPI]
public enum EAccess : byte {

Check warning on line 602 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of EAccess System.Int32 instead of byte

Check warning on line 602 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None,
FamilySharing,
Operator,
Expand All @@ -608,7 +608,7 @@

[Flags]
[PublicAPI]
public enum EBotBehaviour : byte {

Check warning on line 611 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of EBotBehaviour System.Int32 instead of byte

Check warning on line 611 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None = 0,
RejectInvalidFriendInvites = 1,
RejectInvalidTrades = 2,
Expand All @@ -620,7 +620,7 @@
}

[PublicAPI]
public enum EFarmingOrder : byte {

Check warning on line 623 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of EFarmingOrder System.Int32 instead of byte

Check warning on line 623 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
Unordered,
AppIDsAscending,
AppIDsDescending,
Expand All @@ -641,7 +641,7 @@

[Flags]
[PublicAPI]
public enum EFarmingPreferences : ushort {

Check warning on line 644 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of EFarmingPreferences System.Int32 instead of ushort

Check warning on line 644 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None = 0,
FarmingPausedByDefault = 1,
ShutdownOnFarmingFinished = 2,
Expand All @@ -650,14 +650,13 @@
SkipRefundableGames = 16,
SkipUnplayedGames = 32,
EnableRiskyCardsDiscovery = 64,
AutoSteamSaleEvent = 128,
AutoUnpackBoosterPacks = 256,
All = FarmingPausedByDefault | ShutdownOnFarmingFinished | SendOnFarmingFinished | FarmPriorityQueueOnly | SkipRefundableGames | SkipUnplayedGames | EnableRiskyCardsDiscovery | AutoSteamSaleEvent | AutoUnpackBoosterPacks
All = FarmingPausedByDefault | ShutdownOnFarmingFinished | SendOnFarmingFinished | FarmPriorityQueueOnly | SkipRefundableGames | SkipUnplayedGames | EnableRiskyCardsDiscovery | AutoUnpackBoosterPacks
}

[Flags]
[PublicAPI]
public enum EOnlinePreferences : byte {

Check warning on line 659 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of EOnlinePreferences System.Int32 instead of byte

Check warning on line 659 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None = 0,
IsSteamDeck = 1,
All = IsSteamDeck
Expand All @@ -665,7 +664,7 @@

[Flags]
[PublicAPI]
public enum ERedeemingPreferences : byte {

Check warning on line 667 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of ERedeemingPreferences System.Int32 instead of byte

Check warning on line 667 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None = 0,
Forwarding = 1,
Distributing = 2,
Expand All @@ -676,7 +675,7 @@

[Flags]
[PublicAPI]
public enum ERemoteCommunication : byte {

Check warning on line 678 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of ERemoteCommunication System.Int32 instead of byte

Check warning on line 678 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None = 0,
SteamGroup = 1,
PublicListing = 2,
Expand All @@ -685,7 +684,7 @@

[Flags]
[PublicAPI]
public enum ETradingPreferences : byte {

Check warning on line 687 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Enum Storage should be Int32 

If possible, make the underlying type of ETradingPreferences System.Int32 instead of byte

Check warning on line 687 in ArchiSteamFarm/Steam/Storage/BotConfig.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

RoslynAnalyzers Consider making public types internal 

Because an application's API isn't typically referenced from outside the assembly, types can be made internal
None = 0,
AcceptDonations = 1,
SteamTradeMatcher = 2,
Expand Down
Loading