Add Pipenv for Managing Dependencies #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that one of your TODO items is "Add requirments.txt file from pip freeze to create easy dependencies install". Decided to give it a shot, so let me know what you think.
This PR to implements pipenv for dependency management. Personally, I think the requirements file alone is a little messy and hard to manage when you have multiple python projects. If you absolutely need a requirements.txt file, there is a way to generate it using pipenv by running
pipenv lock -r > requirements.txt.To test my changes I had to change this line to False:
plane-notify/planeClass.py
Line 177 in 1d7bc62
After that, it appears to start up fine with no data sources.