Fix for preheat selecting the wrong device #1763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# TERN_(ANY()) failed to compile on LPC1769, reverted
|
The bug has been fixed in mainline (based on the same code as here). It will be fixed with the next pull from upstream. However, I am leaving this open as a note to users searching for information on fixing it themselves until then. Feel free to close once upstream is pulled. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description
This fix updates Marlin's code so that the Preheat selection applies to the correct device.
Benefits
See #1651 for information; the bug was caused by passing in a value to the TEST() macro that had already been bit-shifted, and then having it be shifted again.
Related Issues
#1651