Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stretcher - Rework helistretcher to use ace interaction menu #571

Conversation

MiszczuZPolski
Copy link
Collaborator

@MiszczuZPolski MiszczuZPolski commented Aug 1, 2024

When merged this pull request will:

  • Rework helistretcher to use ace interaction menu

TODO:
[x] test in MP
[x] move out stretcher related stuff (including this) into separate addon
[x] possibly improve conditions for actions so you cant adjust ropes during function call

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@MiszczuZPolski MiszczuZPolski added the kind/enhancement Release Notes: **IMPROVED:** label Aug 1, 2024
@MiszczuZPolski MiszczuZPolski added this to the 2.15.1 milestone Aug 1, 2024
Copy link
Contributor

@mazinskihenry mazinskihenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things, largely headers and a few EFUNCs to ACEFUNCs

addons/stretcher/functions/fnc_canPackIntoBag.sqf Outdated Show resolved Hide resolved
* None
*
* Example:
* [cursorTarget] call kat_stretcher_fnc_packIntoBackpack;
Copy link
Contributor

@mazinskihenry mazinskihenry Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got a player and a target, you need both on the header

Suggested change
* [cursorTarget] call kat_stretcher_fnc_packIntoBackpack;
* [player, cursorTarget] call kat_stretcher_fnc_packIntoBackpack;

addons/stretcher/functions/fnc_raiseHeliStretcher.sqf Outdated Show resolved Hide resolved
addons/stretcher/functions/fnc_retractHeliStretcher.sqf Outdated Show resolved Hide resolved
addons/stretcher/functions/fnc_deployHeliStretcher.sqf Outdated Show resolved Hide resolved
addons/stretcher/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/stretcher/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/stretcher/CfgVehicles.hpp Outdated Show resolved Hide resolved
addons/stretcher/CfgVehicles.hpp Outdated Show resolved Hide resolved
@MiszczuZPolski MiszczuZPolski modified the milestones: 2.15.1, 2.16.0 Aug 6, 2024
Copy link
Contributor

@mazinskihenry mazinskihenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header issues

addons/stretcher/functions/fnc_canPackIntoBackpack.sqf Outdated Show resolved Hide resolved
addons/stretcher/functions/fnc_canPackIntoBackpack.sqf Outdated Show resolved Hide resolved
addons/stretcher/functions/fnc_canPackIntoBag.sqf Outdated Show resolved Hide resolved
addons/stretcher/functions/fnc_deployHeliStretcher.sqf Outdated Show resolved Hide resolved
Copy link
Contributor

@mazinskihenry mazinskihenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to ball 😈

APPROVED

@MiszczuZPolski MiszczuZPolski merged commit 02acfea into KAT-Advanced-Medical:dev-Tomcat Aug 29, 2024
3 checks passed
@MiszczuZPolski MiszczuZPolski deleted the heliStretcherRework branch August 29, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants