Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register QUuid container types with QML #1172

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

jnbooth
Copy link
Contributor

@jnbooth jnbooth commented Feb 2, 2025

This is an addon to #1149 that adds qRegisterMetaType calls for QList_QUuid, QSet_QUuid, and QVector_QUuid. This should have been part of the original PR, but I didn't know about the qRegisterMetaType system in cxx-qt-lib/src/core/init.cpp at the time.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cdc5ef9) to head (9c2255b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines        11967     11967           
=========================================
  Hits         11967     11967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
That is actually a good reminder that we should probably auto-generate these initializers as well, as it's confusing that we have to do this manually where the rest is auto-generated...

@LeonMatthesKDAB LeonMatthesKDAB merged commit d1a9ded into KDAB:main Feb 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants