Qvector header cleanup #1173
Merged
Qvector header cleanup #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 27, 2025 15:58
The files were created because the Rust bridges, which are specific, included qvector, which is generic. This, in turn, included all possible types of qvector, even though only the type required by the bridge was actually needed. (Run-time: n^2) With the change, each spefific bridge now has its own specific qvector that it can include. The only downside is, that the user has to manually include the specific qvector header.
- fixing clang-format error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11967 11967
=========================================
Hits 11967 11967 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files were created because the Rust bridges, which are specific, included qvector, which is generic.
This, in turn, included all possible types of qvector, even though only the type required by the bridge was actually needed.
(Run-time: n^2)
With the change, each spefific bridge now has its own specific qvector that it can include.
The only downside is, that the user has to manually include the specific qvector header.