Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span to callables generation to improve error messages #1175

Merged

Conversation

BenFordTytherington
Copy link
Collaborator

@BenFordTytherington BenFordTytherington commented Feb 3, 2025

Fix for #1171

  • Stops adding signals to typenames
  • Improves errors

@BenFordTytherington BenFordTytherington marked this pull request as ready for review February 3, 2025 15:56
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2cf1b4a) to head (c0196e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines        12426     12438   +12     
=========================================
+ Hits         12426     12438   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-) It seems unclear why the signals were added only in C++Qt to the TypeNames before, likely a mistake. So lets go with this as it doesn't appear to break anything and allows for signals with the same name on different QObjects.

@ahayzen-kdab ahayzen-kdab merged commit 0acc26b into KDAB:main Feb 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants