Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.4.0 #315

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Version 1.4.0 #315

merged 2 commits into from
Jan 20, 2022

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Jan 20, 2022

  • Bumps pallet versions to 1.4.0 from 1.3.0
  • Bumps spec versions to 10400 from 10310

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
  • I have documented the changes (where applicable)

@wischli wischli requested review from weichweich and ntn-x2 January 20, 2022 11:25
@weichweich
Copy link
Contributor

weichweich commented Jan 20, 2022

normally we do

             merge develop
             |   version 1.4.0
             |   |    other commits
             |   |    |
master ------*---*----*-----------
            /          \
develop ----------------*---------
                        |
                        merge back to develop

Not sure if we want keep that. But it worked in the past

@wischli
Copy link
Contributor Author

wischli commented Jan 20, 2022

normally we do


             merge develop

             |   version 1.4.0

             |   |    other commits

             |   |    |

master ------*---*----*-----------

            /          \

develop ----------------*---------

                        |

                        merge back to develop

Not sure if we want keep that. But it worked in the past

Thats also what I thought but then you merged 1.3.0 in #305 into develop.

@wischli wischli changed the base branch from develop to master January 20, 2022 12:43
@wischli wischli merged commit 0d1d124 into master Jan 20, 2022
@wischli wischli deleted the wf-version-1.4.0 branch January 20, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants