Handle paths without DriveInfo #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On a Linux system with a ZFS root filesystem, trying to use a ZFS filesystem for the download cache or the game folder throws
Argumentexceptions inDriveInfo's constructor, which then breaks lots of other things:Cause
DriveInfois supposed to represent the partition associated with the given path, but Mono can only find it if the device's path starts with a/character in the listing in/etc/mtab. ZFS filesystems instead use devices starting withrpool/, so they're ignored (see discussion in #4251 for investigation with source code excerpts). If the root is also ZFS, then no device is found, andArgumentExceptionis thrown.Changes
Now if this exception is thrown, we catch it and give up on trying to figure out that path's free space. This should allow ZFS filesystems to be used, but without the protections afforded by checking the free space before installation.
Fixes #4251.