Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument the KSPe Install Checker to detect when the user deleted the Add'On Directory and kill yourself from GameData #65

Closed
Lisias opened this issue Nov 20, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Lisias
Copy link
Collaborator

Lisias commented Nov 20, 2023

Users willing to remove KSPe are being bitten by 000_KSPe.dll that is usually left behind after deleting GameData/000_KSPe.

Instrument the KSPe.InstallChecker (aka 000_KSPe.dll) to detect when the main distribution is removed, and then remove 001_KSPe.dll to avoid KSPe from being installed on the rig.

The 000_KSPe.dll itself will linger on GameData, as It can't remove itself while running and once it's not running, it can't remove itself neither. This thing should be left on a completely dormant way, and a message on KSP.log should be issue telling the user that he can remove the file manually if desired.

@Lisias Lisias added the bug Something isn't working label Nov 20, 2023
@Lisias Lisias self-assigned this Nov 20, 2023
This was referenced Mar 24, 2024
@Lisias Lisias modified the milestones: 2.5.4.0, 2.5.5.0 Mar 24, 2024
Lisias added a commit that referenced this issue Mar 29, 2024
@Lisias
Copy link
Collaborator Author

Lisias commented Mar 29, 2024

Implemented on commit 237b957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant