Fix Webpack global function definition, including hot module replacement #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix global function definition, such as hot module update.
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
======================================
Coverage 82.5% 82.5%
======================================
Files 77 77
Lines 4390 4390
Branches 767 767
======================================
Hits 3622 3622
Misses 665 665
Partials 103 103Continue to review full report at Codecov.
|
edemaine
approved these changes
Jun 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
globalObjectto an expression as a workaround in #1401 resulted in codes liketypeof self !== 'undefined' ? self : this["webpackHotUpdatekatex"] =, which breaks global function definition such as HMR, due to operator precedence.