Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approximate font metrics only when metrics don't exist #1898

Merged
merged 2 commits into from
Apr 6, 2019
Merged

Approximate font metrics only when metrics don't exist #1898

merged 2 commits into from
Apr 6, 2019

Conversation

ylemkimon
Copy link
Member

Fix non-existent metrics error for \eth.

Fix non-existent metrics error for \eth
@codecov-io
Copy link

Codecov Report

Merging #1898 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   94.76%   94.76%   +<.01%     
==========================================
  Files          79       79              
  Lines        4663     4664       +1     
  Branches      813      813              
==========================================
+ Hits         4419     4420       +1     
  Misses        220      220              
  Partials       24       24
Flag Coverage Δ
#screenshotter 88.94% <100%> (ø) ⬆️
#test 86.79% <66.66%> (-0.02%) ⬇️
Impacted Files Coverage Δ
src/fontMetrics.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f4809...91dbed9. Read the comment docs.

@KaTeX KaTeX deleted a comment from codecov-io Mar 24, 2019
Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Thanks for making this change.

@codecov-io
Copy link

codecov-io commented Apr 6, 2019

Codecov Report

Merging #1898 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   94.83%   94.83%   +<.01%     
==========================================
  Files          79       79              
  Lines        4783     4784       +1     
  Branches      845      845              
==========================================
+ Hits         4536     4537       +1     
  Misses        223      223              
  Partials       24       24
Flag Coverage Δ
#screenshotter 89.33% <100%> (ø) ⬆️
#test 85.82% <66.66%> (-0.02%) ⬇️
Impacted Files Coverage Δ
src/fontMetrics.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c95d8...10f993e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants