Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] tests in repository #254

Closed
Kaaveh opened this issue Feb 7, 2025 · 0 comments · Fixed by #255
Closed

[refactor] tests in repository #254

Kaaveh opened this issue Feb 7, 2025 · 0 comments · Fixed by #255
Assignees
@Kaaveh
Labels
refactor

Comments

@Kaaveh
Copy link
Owner

Kaaveh commented Feb 7, 2025

Refactor all test cases in the data:market-repository module.
@Kaaveh Kaaveh added the refactor label Feb 7, 2025
@Kaaveh Kaaveh self-assigned this Feb 7, 2025
Kaaveh added a commit that referenced this issue Feb 7, 2025
@Kaaveh
[refactor] Relocate Market DTO and Entity Mapper Tests #254
05ef060 
This commit relocates the Market DTO and Entity Mapper tests to improve the project structure.
- Moves `MarketDtoMapperTest` and `MarketEntityMapperTest` from `ir.composenews.data.repository.mapper` to `ir.composenews.data.mapper`.
- Deletes the now-empty `MarketDtoMapperTest` and `MarketEntityMapperTest` files in the `repository` package.
- Creates `MarketDtoMapperTest` and `MarketEntityMapperTest` files in `mapper` package.
Kaaveh added a commit that referenced this issue Feb 7, 2025
@Kaaveh
[test] MarketChartDtoMapper #254
64ba71a 
This commit adds comprehensive tests for the `MarketChartDtoMapper` which is responsible for converting `MarketChartResponse` to `Chart`.

The tests cover various scenarios:

-   Conversion of valid market chart responses.
-   Handling of empty prices.
-   Handling of negative timestamps and prices.
-   Handling of zero values.
-   Handling of large double values.
-   Truncation of decimals in non-integer timestamps.
-   Handling of missing elements in price pairs, throwing `IndexOutOfBoundsException`.
Kaaveh added a commit that referenced this issue Feb 7, 2025
@Kaaveh
[test] handling null or invalid market detail response #254
08ad357 
This commit introduces a new test suite `MarketDetailDtoMapperKtTest` to specifically address scenarios where the market detail response might contain null or invalid data.

**Key changes:**

*   Added test cases to handle `null` values for `id`, `name`, and `marketCapRank` in the `MarketDetailResponse`.
*   Added test cases to handle `null` `marketData` within `MarketDetailResponse`.
*   Added test cases to handle `null` fields within `marketData` like `high24h`, `low24h`, `marketCap`, and `marketCapRank`.
*   Added test cases for handling negative and zero values in market data.
*   Refactored test assertions to compare against expected default values when `null` is present.
*   Implemented custom `shouldBeEqual` functions for more readable assertions.
*   These test cases ensure the robustness of the mapping logic, especially when dealing with incomplete or faulty external data.
*   The new test cases verify that default values are assigned properly when data is null.
*   The new test cases verify that zero values and negative values are handled properly.
* The test cases ensures the response will be associated with the request.
@Kaaveh Kaaveh mentioned this issue Feb 7, 2025
Merged
Kaaveh added a commit that referenced this issue Feb 7, 2025
@Kaaveh
[bug] QuadLineChart #254
65a6da9
Kaaveh added a commit that referenced this issue Feb 8, 2025
@Kaaveh
[refactor] Rename Chart to MarketChart #254
89fd070 
- Renamed `Chart` to `MarketChart` for better clarity.
- Updated all references of `Chart` to `MarketChart` across the codebase.
- Modified mapper to return `MarketChart`.
- Updated use case to return `MarketChart`.
- Updated repository to work with `MarketChart`.
- Updated view model, test cases and UI test.
- Updated contract to work with `MarketChart`.
Kaaveh added a commit that referenced this issue Feb 8, 2025
@Kaaveh
[refactor] Update MarketChartDtoMapperKtTest to use `toMarketChart(…
6f94c7e 
…)` and improve assertions #254

The `MarketChartDtoMapperKtTest` has been refactored to use the `toMarketChart()` function instead of `toChart()`. Additionally, the assertions have been updated to be more concise and efficient, using `shouldContainExactly` for a more direct comparison of the `MarketChart` to the `MarketChartResponse`. Also a infix function `shouldContainExactly` added for easier checking.
Kaaveh added a commit that referenced this issue Feb 8, 2025
@Kaaveh
[refactor] Remove FakeMarketsApi and update MarketRepositoryImpl #254
df380b7 
- Removed `FakeMarketsApi` class.
- Updated `MarketRepositoryImpl`:
  - Refactored `toggleFavoriteMarket` to use `marketEntity` for clarity.
  - Refactored error handling in `fetchChart` and `fetchDetail` using more compact syntax.
Kaaveh added a commit that referenced this issue Feb 8, 2025
@Kaaveh
[refactor] Replace NewsRepositoryImplTest with MarketRepositoryImplTest
e4bf582 
#254

- Delete `NewsRepositoryImplTest` file
- Create `MarketRepositoryImplTest` file with comprehensive tests for `MarketRepositoryImpl`
- Add test cases for `getMarketList`, `getFavoriteMarketList`, `syncMarketList`, `toggleFavoriteMarket`, `fetchChart`, and `fetchDetail` functions
- Implement test cases for successful and failed API calls
- Add new constants for database `FALSE` and `TRUE` values
- Add test cases for different scenarios including database, and api interactions.
Kaaveh added a commit that referenced this issue Feb 8, 2025
@Kaaveh
[refactor] Improve assertion in MarketChartDtoMapperKtTest #254
7298410 
- Refactored the assertion logic in `MarketChartDtoMapperKtTest` to use `shouldBe 2` instead of the previous `if` check.
- Removed the previous `IndexOutOfBoundsException` for this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kaaveh Kaaveh

Labels
refactor
Projects
Compose news
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft: Refactor repository module's tests Kaaveh/ComposeNews
1 participant
@Kaaveh