Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 46 #50

Closed
wants to merge 3 commits into from
Closed

Issue 46 #50

wants to merge 3 commits into from

Conversation

DinahLin
Copy link

@DinahLin DinahLin commented Oct 5, 2018

I change the CSS for Banner. I add the font in the styles.css that (text-dec) part.

This was referenced Oct 5, 2018
@DinahLin
Copy link
Author

DinahLin commented Oct 5, 2018

#46 Problem Fix

@akshat157
Copy link
Member

Hi! If its a visual addition/modification, can you include a preview here? Say a snapshot of the new design? It'd be easier to review then. 🙂

@DinahLin DinahLin closed this Oct 15, 2018
@DinahLin
Copy link
Author

DinahLin commented Oct 15, 2018

Hi! If its a visual addition/modification, can you include a preview here? Say a snapshot of the new design? It'd be easier to review then. 🙂

Sure, I change the css part. In the .text-dec part, I change padding ,margin and
add the font-family:"Trebuchet MS", Arial, Helvetica, sans-serif.

@DinahLin DinahLin reopened this Oct 15, 2018
@abhigyank
Copy link
Member

@DinahLin He means a screenshot of the webpage after the changes. It is helpful if you post those.

@abhigyank
Copy link
Member

Not a visual improvement on the current design, hence closing.

@abhigyank abhigyank closed this Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants