Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme based on 1.0.2 release #131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bidrohi
Copy link

@bidrohi bidrohi commented Jan 4, 2025

No description provided.

@bidrohi
Copy link
Author

bidrohi commented Jan 4, 2025

Weird, not sure why the whole file is showing up as changed....

Copy link
Member

@luca992 luca992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the pr. I can't see what you changed

@bidrohi bidrohi reopened this Jan 13, 2025
@bidrohi
Copy link
Author

bidrohi commented Jan 13, 2025

Ok, looks like the weird diff issue is gone. Thanks you for your patience

@luca992
Copy link
Member

luca992 commented Jan 13, 2025

@bidrohi appreciate it, but I think you are confused, KamelConfig.Default is what most people should be using not KamelConfig.Core perhaps it should be more clearly noted in https://github.com/Kamel-Media/Kamel?tab=readme-ov-file#default-setup that implementation("media.kamel:kamel-image-default:") is needed for use of KamelConfig.Default

KamelConfig.Core is really only a shortcut to add all the features contained in the core module if you want to do the granular setup.

@bidrohi
Copy link
Author

bidrohi commented Jan 15, 2025

aah.. you are correct. I guess my confusion came from thinking that KamelConfig.Default is available even when not including the default change.

I can drop that change or explicitly add something like

The default implementation is KamelConfig.Default, or it can built on top of KamelConfig.Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants