-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle login non JSON response #640
Conversation
aiounifi/tests/test_controller.py Line 41 in 5452ff3
I read that wrong :) Sending html not receiving :) |
Sorry about all of the "noise" - this should be the "final answer" - original tests still pass, new test covers the new code AND it actually fixes the startup problem :) |
Awesome! Don't worry about it. I looked through it but will review tonight |
Thanks |
Have you validated that this works in reality? |
Yes, I tested with my configuration. As long as the host is returning "starting" with text/html the old code failed, this code triggers HA to retry the integration until it returns the "correct" login info. |
Great! Will put up a new release tonight |
This handles the non JSON response and causes retries until the host is "alive"
There may be a better way to handle things. I selected .debug for the log as it "spams" the log file with errors during a "normal" startup