-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for update_stats #657
Conversation
I have more time to look tomorrow. I was also planning on doing this for you but good you got here first :) |
Awesome! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also extend one of the device tests for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
@Kane610
Not sure why? |
I needed to add in fixtures.py. But removing the data in 13772ac don't make it fail? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the test to use a better fixture representable to the where the data can be found for real and this is ready
Removing the data doesn't do anything you remove the data to check against the existence of the data so when you remove it there is no comparison done for the update stats |
78a7140
to
ee373e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
I will do a release shortly |
It will be part of home-assistant/core#116737
This will add typed info for update_stats.WAN.monitors
JSON example from a UDM SE