Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Camel extensions as dependencies #773

Closed
wants to merge 15 commits into from
Closed

Add Camel extensions as dependencies #773

wants to merge 15 commits into from

Conversation

apupier
Copy link
Member

@apupier apupier commented Jan 21, 2025

It allows to have several general Camel features such as Run/debug/Create/Export for users which are installing VS Code Kaoto extension only.

@apupier apupier force-pushed the addDepednencyToCamelSpecificExtensions branch from b4b3675 to 2246940 Compare January 21, 2025 13:55
@apupier
Copy link
Member Author

apupier commented Jan 21, 2025 •
edited
Loading

failure on windows is related to camel-tooling/camel-dap-client-vscode#814
failure on main branch is related to PatternFly 6 update

@apupier apupier force-pushed the addDepednencyToCamelSpecificExtensions branch from 43e910a to d9849d1 Compare January 22, 2025 14:42
@apupier
Add Camel extensions as dependencies
15a643c 
It allows to have several general Camel features such as
Run/debug/Create/Export for users which are installing VS Code Kaoto
extension only.
Give time to Kaoto extension to activate as now there are other
dependent extension to activate before

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier
try increase timeout for activation
fdd4d0d
@apupier
reget the extension object between checks
54c24e5
@apupier
try to activate programmatically to see if we can have more information
0c8f197 
why it was not activated
@apupier
try to activate the debug adapter directly
d50d1d6
@apupier
try to play oonly the activation test as tests ar ento played in same
493e8f7 
order on Windows to see fi it can influence it
@apupier apupier force-pushed the addDepednencyToCamelSpecificExtensions branch from f18845b to 493e8f7 Compare January 23, 2025 09:17
@apupier
Copy link
Member Author

apupier commented Jan 23, 2025 •
edited
Loading

tried on a local windows and the tests are passing.
I see nothing interesting in the VS Code logs, seems just the VS Code Kaoto activation hangs but no error reported anymore...

2025-01-22 19:56:53.911 [info] ExtensionService#_doActivateExtension redhat.vscode-apache-camel, startup: false, activationEvent: 'onStartupFinished'
2025-01-22 19:56:54.668 [info] ExtensionService#_doActivateExtension redhat.vscode-debug-adapter-apache-camel, startup: false, activationEvent: 'onStartupFinished', root cause: redhat.vscode-kaoto
2025-01-22 19:58:35.020 [error] Test runner finished with error 1 test failed.

tried to ask on VS Code extension dev environment chat how to activate more trace https://vscode-dev-community.slack.com/archives/C74CB59NE/p1737627547204059

@apupier
Copy link
Member Author

apupier commented Jan 23, 2025

found this other stack in cli.log file from vs code log:

2025-01-23 09:21:42.106 [error] [uncaught exception in CLI]: Error: ENOENT: no such file or directory, stat 'd:\a\vscode-kaoto\vscode-kaoto\.vscode-test\extensions\extensions.json.vsctmp': EntryNotFound (FileSystemError): Error: ENOENT: no such file or directory, stat 'd:\a\vscode-kaoto\vscode-kaoto\.vscode-test\extensions\extensions.json.vsctmp'
    at R1.create (file:///D:/a/vscode-kaoto/vscode-kaoto/.vscode-test/vscode-win32-x64-archive-1.96.4/resources/app/out/vs/code/node/cliProcessMain.js:45:8825)
    at ni (file:///D:/a/vscode-kaoto/vscode-kaoto/.vscode-test/vscode-win32-x64-archive-1.96.4/resources/app/out/vs/code/node/cliProcessMain.js:45:8932)
    at Sr.ib (file:///D:/a/vscode-kaoto/vscode-kaoto/.vscode-test/vscode-win32-x64-archive-1.96.4/resources/app/out/vs/code/node/cliProcessMain.js:61:22783)
    at Sr.stat (file:///D:/a/vscode-kaoto/vscode-kaoto/.vscode-test/vscode-win32-x64-archive-1.96.4/resources/app/out/vs/code/node/cliProcessMain.js:61:16015)
    at async Ya.stat (file:///D:/a/vscode-kaoto/vscode-kaoto/.vscode-test/vscode-win32-x64-archive-1.96.4/resources/app/out/vs/code/node/cliProcessMain.js:59:56470)
    at async Ga.Ab (file:///D:/a/vscode-kaoto/vscode-kaoto/.vscode-test/vscode-win32-x64-archive-1.96.4/resources/app/out/vs/code/node/cliProcessMain.js:59:38188)
2025-01-23 09:21:43.779 [info] Extracted extension to file:///d%3A/a/vscode-kaoto/vscode-kaoto/.vscode-test/extensions/redhat.vscode-apache-camel-1.9.0: redhat.vscode-apache-camel
2025-01-23 09:21:43.966 [info] Renamed to d:\a\vscode-kaoto\vscode-kaoto\.vscode-test\extensions\redhat.vscode-apache-camel-1.9.0
2025-01-23 09:21:43.974 [info] Extension installed successfully: redhat.vscode-debug-adapter-apache-camel vscode-userdata:/d%3A/a/vscode-kaoto/vscode-kaoto/.vscode-test/extensions/extensions.json
2025-01-23 09:21:43.974 [info] Extension installed successfully: redhat.vscode-apache-camel vscode-userdata:/d%3A/a/vscode-kaoto/vscode-kaoto/.vscode-test/extensions/extensions.json

Which tends to say that the dependent extensiosn were successfully installed but not the kaot oone due to an error on a missing file internal to VS Code

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@apupier apupier mentioned this pull request Jan 24, 2025
Closed
@apupier apupier closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apupier