Fix: Using transition bump with add blend type will produce wrong max…

… height value
Kareemov03 · Sep 1, 2024 · 0f0780b · 0f0780b
1 parent ddcb16f
commit 0f0780b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/lib.blend b/lib.blend
diff --git a/lib.py b/lib.py
@@ -169,7 +169,9 @@
 TB_DELTA_CALC = '~yPL Transition Bump Delta Calculation'
 CH_MAX_HEIGHT_CALC = '~yPL Layer Channel Max Height'
 CH_MAX_HEIGHT_TB_CALC = '~yPL Layer Channel Max Height with Transition Bump'
+CH_MAX_HEIGHT_TB_ADD_CALC = '~yPL Layer Channel Max Height with Transition Bump Add'
 CH_MAX_HEIGHT_TBC_CALC = '~yPL Layer Channel Max Height with Transition Bump Crease'
+CH_MAX_HEIGHT_TBC_ADD_CALC = '~yPL Layer Channel Max Height with Transition Bump Crease Add'
 
 EMULATED_CURVE = '~yPL Emulated Curve'
 EMULATED_CURVE_FLIP = '~yPL Emulated Curve Flip'

diff --git a/subtree.py b/subtree.py
@@ -1809,9 +1809,13 @@ def check_channel_normal_map_nodes(tree, layer, root_ch, ch, need_reconnect=Fals
         # Max Height calculation node
         if ch.enable_transition_bump:
             if ch.transition_bump_crease and not ch.transition_bump_flip:
-                lib_name = lib.CH_MAX_HEIGHT_TBC_CALC
+                if ch.normal_blend_type == 'OVERLAY':
+                    lib_name = lib.CH_MAX_HEIGHT_TBC_ADD_CALC
+                else: lib_name = lib.CH_MAX_HEIGHT_TBC_CALC
             else:
-                lib_name = lib.CH_MAX_HEIGHT_TB_CALC
+                if ch.normal_blend_type == 'OVERLAY':
+                    lib_name = lib.CH_MAX_HEIGHT_TB_ADD_CALC
+                else: lib_name = lib.CH_MAX_HEIGHT_TB_CALC
         else:
             lib_name = lib.CH_MAX_HEIGHT_CALC