Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandrel integration tests suite fails to parse GraalVM/Mandrel version when warnings are present in the output #293

Closed
zakkak opened this issue Oct 24, 2024 · 1 comment · Fixed by #294
Closed

Mandrel integration tests suite fails to parse GraalVM/Mandrel version when warnings are present in the output #293

zakkak opened this issue Oct 24, 2024 · 1 comment · Fixed by #294
Assignees
@zakkak

Comments

@zakkak
Copy link
Collaborator

zakkak commented Oct 24, 2024

E.g. it throws

2024-10-24 11:51:23.628 WARN  [o.g.t.i.u.v.UsedVersion$MVersion] (of) Failed to correctly parse native-image version command output. Is it on PATH? Unknown version format? Output reads in 4 lines, see them in an array: [WARNING: Unknown module: org.graalvm.truffle specified to --enable-native-access, native-image 24-beta 2025-03-18, OpenJDK Runtime Environment Mandrel-24.2.0-deve05805b1084 (build 24-beta+20-ea), OpenJDK 64-Bit Server VM Mandrel-24.2.0-deve05805b1084 (build 24-beta+20-ea, mixed mode)]

when the output is:

WARNING: Unknown module: org.graalvm.truffle specified to --enable-native-access
native-image 24-beta 2025-03-18
OpenJDK Runtime Environment Mandrel-24.2.0-deve05805b1084 (build 24-beta+20-ea)
OpenJDK 64-Bit Server VM Mandrel-24.2.0-deve05805b1084 (build 24-beta+20-ea, mixed mode)

We should ignore the warning and still parse the version to avoid test failures. If we want to test for warnings being present in the version command, then we should have a separate test for it.
@zakkak zakkak mentioned this issue Oct 24, 2024
Closed
@zakkak zakkak self-assigned this Oct 24, 2024
zakkak added a commit to zakkak/mandrel-integration-tests that referenced this issue Oct 24, 2024
@zakkak
Ignore irrelevant output when parsing Mandrel version
4aaa864 
Drop everything until we see "GraalVM" or "native-image" in the output.
This way we can ignore warnings and other output that might be present.

Fixes Karm#293
@zakkak zakkak mentioned this issue Oct 24, 2024
Merged
@jerboaa
Copy link
Collaborator

jerboaa commented Oct 24, 2024

+1

zakkak added a commit that referenced this issue Oct 24, 2024
@zakkak
Ignore irrelevant output when parsing Mandrel version
a323b04 
Drop everything until we see "GraalVM" or "native-image" in the output.
This way we can ignore warnings and other output that might be present.

Fixes #293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakkak zakkak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore irrelevant output when parsing Mandrel version zakkak/mandrel-integration-tests
2 participants
@jerboaa @zakkak