Update dependencies #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonilopezmr
approved these changes
Sep 17, 2019
shared/src/iosMain/kotlin/com/karumi/gallery/data/test/PhotoApiClientStub.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What is the goal?
Update all dependencies in the project to their latest version to start working on flow.
📝 How is it being implemented?
statelyas it is not compatible with the latest ABI version (stately targeted v9 and the project is v14). In order to safely remove it I had to declare the dependency graph as@ThreadLocal, it basically declares Kotlin objects as mutable on the condition of having a different reference per thread. More information here. Luckily we are configuring the test graph and getting all dependencies from the same thread, the main one.delaycall to never finish fetching API information and use it from tests. We were relying on the device slow connection prior to this change, making the test undeterministic.💥 How can it be tested?
🤖 Run all iOS and Android tests.