Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37760 - Pass updateParamsByUrl: false to Pagination component #11121

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Aug 27, 2024

What are the changes introduced in this pull request?

Pass updateParamsByUrl as false from PageControls.js

Considerations taken when implementing this change?

What are the testing steps for this pull request?

To test:
Create some test data for CV UI.

100.times do |i|
  cv1 = cv.dup  
  cv1.label='test'+i.to_s  
  cv1.name = 'test'+i.to_s  
  cv1.save!
end 

Go to Content View page.
Try moving around pages of results using the pagination component on top and bottom of table.

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination on the content views page works now! Also confirmed it works on the install packages action modal for individual hosts.

@sjha4 sjha4 merged commit c2146ec into Katello:master Aug 28, 2024
26 checks passed
chris1984 pushed a commit to chris1984/katello that referenced this pull request Sep 4, 2024
chris1984 pushed a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants